Ticket #3316 (closed task: fixed)

Opened 2 years ago

Last modified 22 months ago

no need for a drawing property in Handler.Path

Reported by: erilem Owned by: tschaub
Priority: trivial Milestone: 2.11 Release
Component: Handler.Point Version: 2.11 RC1
Keywords: Cc: xavier.mamano@…
State: Pullup

Description

As mentioned in #3315 "this.drawing is set to false in the Handler.Point.finalize method...but it is otherwise not being set" or read...

We can just remove that statement.

Attachments

patch-3316-A0.diff Download (492 bytes) - added by erilem 2 years ago.

Change History

Changed 2 years ago by erilem

  Changed 2 years ago by erilem

  • state set to Review

Trivial change. All tests continue to pass. Please review.

in reply to: ↑ description   Changed 2 years ago by jorix

Replying to erilem:

As mentioned in #3315 "this.drawing is set to false in the Handler.Point.finalize method...but it is otherwise not being set" or read... We can just remove that statement.

Yes, but see:  http://trac.osgeo.org/openlayers/ticket/3315#comment:7

  Changed 2 years ago by jorix

  • cc xavier.mamano@… added

  Changed 23 months ago by erilem

(In [12153]) Handler.Point has no "drawing" property anymore, trivial change (references #3316)

  Changed 23 months ago by erilem

  • state changed from Review to Pullup

  Changed 22 months ago by ahocevar

  • status changed from new to closed
  • resolution set to fixed

in 2.11-rc2

Note: See TracTickets for help on using tickets.