DrawFeature control in freehand mode produces invalid geometries

[rayd]

To test this out I used the the draw feature example here:  http://dev.openlayers.org/releases/OpenLayers-2.10/examples/draw-feature.html

Use a DrawFeature control in freehand mode with a Path handler to draw a line. Instead of dragging the mouse, just click once -- you will get a feature with a LINESTRING geometry with only one point. You can use a tool like Firebug to inspect the created features. Similarly, use a DrawFeature control in freehand mode with a Polygon handler. Just click once on the map, and you will get a feature with a POLYGON geometry with a LinearRing geometry with only two points. This shouldn't happen since those are technically invalid geometries.

I would think in this situation we're just better off not adding the feature to the layer in the first place.

[jorix]

Add tests pending. Requires #3311

[jorix]

It's simpler, and add tests.

[jorix]

This problem is due to two bugs. One in up method of Handler.Path and the other in the clone method of Geometry.LinearRing (see #3311)

3310.1.patch requires patch  3311.3.patch

[erilem]

No need freehand to draw invalid geometries, one can easily draw two-point polygons for example. At this point I don't know whether we want to disallow drawing invalid geometries.

I think the discussion should happen outside the 2.11 scope. Please set the milestone back to 2.11 if you think otherwise.

Btw, could you confirm that these bugs existed in 2.10?

[jorix]

Replying to erilem:

I think the discussion should happen outside the 2.11 scope. Please set the milestone back to 2.11 if you think otherwise.

"rayd" put it in 2.11 and I do not touch. For me is OK in 2.12

Btw, could you confirm that these bugs existed in 2.10?

Yes 2.10, 2.9 and 2.8 and I have not tested further back.

[rayd]

Oh I had only put in 2.11 since it hadn't been released yet and was following the bug reporting protocol. I'm alright with it being in 2.12 -- I don't see why we'd want to allow invalid geometries, but you're right that it shouldn't hold up 2.11.

Replying to jorix:

Replying to erilem:

I think the discussion should happen outside the 2.11 scope. Please set the milestone back to 2.11 if you think otherwise.

"rayd" put it in 2.11 and I do not touch. For me is OK in 2.12

Btw, could you confirm that these bugs existed in 2.10?

Yes 2.10, 2.9 and 2.8 and I have not tested further back.

[jorix]

I see no need to work more on this subject, I agree with what he says erilem:

"No need freehand to draw invalid geometries, one can easily draw two-point polygons for example. At this point I don't know whether we want to disallow drawing invalid geometries."