Ticket #3304 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

TRANSPARENT value violates WMS standard

Reported by: ahocevar Owned by: euzuro
Priority: minor Milestone: 2.11 Release
Component: Layer.WMS Version: 2.10
Keywords: Cc:
State: Commit

Description

The WMS standard (confirmed for 1.1.1 and 1.3.0) demands that the TRANSPARENT param has two valid values, "TRUE" and "FALSE". OpenLayers uses "true" and "false".

From the WMS 1.1.1 spec:

6.4.1 Parameter Ordering and Case

Parameter names shall not be case sensitive, but parameter values shall be case sensitive. In this document, parameter names are typically shown in uppercase for typographical clarity, not as a requirement.

7.2.3.9 TRANSPARENT

The optional TRANSPARENT parameter specifies whether the map background is to be made transparent or not. TRANSPARENT can take on two values, "TRUE" or "FALSE". The default value is FALSE if this parameter is absent from the request.

Attachments

transparent.patch Download (4.3 KB) - added by ahocevar 2 years ago.

Change History

Changed 2 years ago by ahocevar

Changed 2 years ago by ahocevar

  • state set to Review

The attached patch fixes the issue. The change only applies to cases where the TRANSPARENT param is provided as boolean value.

Patch with tests; all tests pass in Safari5. Thanks for any review.

Changed 2 years ago by bartvde

  • state changed from Review to Commit

Thanks for finally tackling this Andreas, please commit.

Btw, I think it's a safe change for 2.11 (I don't know if 2.11 has been branched already).

Changed 2 years ago by ahocevar

  • status changed from new to closed
  • resolution set to fixed

(In [11984]) making TRANSPARENT param values all UPPERCASE to conform to the WMS spec. r=bartvde (closes #3304)

Changed 2 years ago by ahocevar

  • milestone changed from 2.12 Release to 2.11 Release
Note: See TracTickets for help on using tickets.