Ticket #3294 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Panel: Allow deactivate tool controls by clicking the icon that represents them

Reported by: jorix Owned by:
Priority: minor Milestone: 2.11 Release
Component: general Version: 2.10
Keywords: Cc:
State: Review

Description

See discussion at  3271#comment:4

Attachments

3294.patch Download (2.9 KB) - added by jorix 2 years ago.
3294.2.patch Download (2.9 KB) - added by jorix 2 years ago.

Change History

Changed 2 years ago by jorix

  Changed 2 years ago by jorix

  • state set to Review

The patch adds tests to the panel.

The test of all controls work.

follow-up: ↓ 3   Changed 2 years ago by erilem

Review comments:

  • I'd rather have allowDepress default to false, to maintain the current behavior.
  • In the new doc text TYPE_TOGGLE should be TYPE_TOOL.
  • I'd prefer a separate test function for allowDepress (I always prefer separate test functions)

in reply to: ↑ 2   Changed 2 years ago by jorix

Replying to erilem:

Review comments: * I'd rather have allowDepress default to false, to maintain the current behavior.

ok

* In the new doc text TYPE_TOGGLE should be TYPE_TOOL.

oops!

* I'd prefer a separate test function for allowDepress (I always prefer separate test functions)

ok

New patch attached.

Changed 2 years ago by jorix

  Changed 2 years ago by erilem

  • status changed from new to closed
  • resolution set to fixed

(In [11965]) allow toggling TYPE_TOOL controls in panels, p=jorix, r=me (closes #3294)

Note: See TracTickets for help on using tickets.