Ticket #3277 (reopened bug)

Opened 2 years ago

Last modified 21 months ago

DragFeature control should trigger afterfeaturemodified

Reported by: bartvde Owned by: tschaub
Priority: minor Milestone: 2.13 Release
Component: Control.DragFeature Version: 2.10
Keywords: Cc:
State: Needs More Work

Description

In the doneDragging function the afterfeaturemodified event should be triggered on the layer, just like the ModifyFeature Control does.

Attachments

ol-3277.patch Download (4.1 KB) - added by bartvde 2 years ago.

Change History

Changed 2 years ago by bartvde

The same applies to the beforefeaturemodified and featuremodified events.

Changed 2 years ago by bartvde

I'll attach a patch which implements this, one omission currently is that beforefeaturemodified can not be used to cancel the modification, but this would probably require changes to the Drag Handler as well, so I could argue this deserves an additional ticket.

Changed 2 years ago by bartvde

Changed 2 years ago by bartvde

  • state set to Review
  • type changed from feature to bug
  • milestone changed from 2.12 Release to 2.11 Release

Tests pass in FF3.6 and Safari 5, please review.

PS feel free to bump to 2.12 since this is not a regression.

Changed 2 years ago by bartvde

  • milestone changed from 2.11 Release to 2.12 Release

Not critical for 2.11 so moving to 2.12

Changed 21 months ago by crschmidt

  • state changed from Review to Commit

This looks fine. Feel free to commit.

Changed 21 months ago by bartvde

  • status changed from new to closed
  • resolution set to fixed

Changed 21 months ago by bartvde

  • status changed from closed to reopened
  • state changed from Commit to Needs More Work
  • resolution fixed deleted

I've reverted this change since it was causing issues see #3527, se reopening and changing status to needs more work.

Note: See TracTickets for help on using tickets.