Ticket #3273 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

make the Navigation control support pinch-zoom

Reported by: erilem Owned by: erilem
Priority: minor Milestone: 2.11 Release
Component: Control.Navigation Version: SVN
Keywords: mobile Cc:
State: Needs More Work

Description

This ticket suggest making the Navigation control support pinch-zoom by default *if* the PinchZoom constructor is defined (PinchZoom.js is included in OpenLayers.js)

See  http://osgeo-org.1803224.n2.nabble.com/PinchZoom-in-Navigation-td6289661.html for the full discussion.

Attachments

patch-3273-A0.diff Download (4.2 KB) - added by erilem 2 years ago.

Change History

Changed 2 years ago by erilem

  Changed 2 years ago by erilem

  • state set to Review

See patch-3273-A0.diff Download. The Navigation.html tests pass in FF4 and IE8. Please review.

  Changed 2 years ago by erilem

  • owner set to bbinet

follow-up: ↓ 4   Changed 2 years ago by bbinet

  • owner changed from bbinet to erilem
  • state changed from Review to Needs More Work

We need to check that this.pinchZoom control is not null in activate and deactivate methods since the ticket abstract says: "making the Navigation control support pinch-zoom by default *if* the PinchZoom constructor is defined".

Once this is done, this should be good for commit.

in reply to: ↑ 3   Changed 2 years ago by erilem

Replying to bbinet:

We need to check that this.pinchZoom control is not null in activate and deactivate methods since the ticket abstract says: "making the Navigation control support pinch-zoom by default *if* the PinchZoom constructor is defined". Once this is done, this should be good for commit.

Thanks for the sharp eyes. Modifying the patch just now...

  Changed 2 years ago by erilem

  • status changed from new to closed
  • resolution set to fixed

(In [11961]) make the Navigation control support pinch-zoom, r=bbinet (closes #3273)

Note: See TracTickets for help on using tickets.