Ticket #3269 (new feature)

Opened 2 years ago

Last modified 20 months ago

EditingToolbar: Enable to pan the map while drawing.

Reported by: jorix Owned by:
Priority: minor Milestone: 2.13 Release
Component: Control.EditingToolbar Version: 2.10
Keywords: Cc:
State: Needs Discussion

Description

May be interesting to enable this option in this control.

This control is almost just an example. But for being an example, it is interesting that supports this new feature, introduced in 2.11 (r11381)

Caution: This ticket using part of #3268. Once fixed this bug, should be a merge before applying this patch.

Attachments

pan-draw-3269.patch Download (3.3 KB) - added by jorix 2 years ago.

Change History

Changed 2 years ago by jorix

  Changed 2 years ago by jorix

  • state set to Review

(the patch does not contain testing. This control has no defined tests)

please review.

  Changed 2 years ago by jorix

  • summary changed from EditingToolbar: Enable pan while drawing. to EditingToolbar: Enable to pan the map while drawing.

  Changed 2 years ago by jorix

  • milestone changed from 2.12 Release to 2.11 Release

Initially I put this ticket in 2.12, because I thought that 2.11 RC was going to close within a few days.

It is interesting to apply this patch on the same Milestone that r11381

Please review.

follow-up: ↓ 6   Changed 2 years ago by erilem

  • state changed from Review to Needs Discussion

As I said already I'm not a big fan of introducing more logic in the EditingToolbar, especially when it's logic that is a bit hackish like this. I'd rather introduce a custom-editingtoobar example, that shows how to build a custom editing toolbar, that, for example, includes more controls and allows "pan while drawing".

  Changed 2 years ago by ahocevar

I agree with erilem here.

in reply to: ↑ 4   Changed 2 years ago by jorix

Replying to erilem:

... I'd rather introduce a custom-editingtoobar example, that shows how to build a custom editing toolbar, that, for example, includes more controls and allows "pan while drawing".

Thinking about this...

I think interesting add in the file "editing_tool_bar.png" some icons: remove_point, save_features, and one more specific to modify features. (and rule?)

This would allow a CSS code shorter and optimized.

You think right?

  Changed 20 months ago by jorix

I see no need to work on this with the possibility of using allowDepress in the panels.

Maybe set EditingToolbar as deprecated, and think of the example custom-editingtoobar but in another ticket.

Note: See TracTickets for help on using tickets.