Ticket #3254 (new bug)

Opened 2 years ago

Last modified 2 years ago

same id used for all Popup-div parts

Reported by: pebXX2346 Owned by:
Priority: major Milestone: 2.13 Release
Component: Popup.Framed Version: 2.10
Keywords: Cc:
State:

Description

All FramedCloudPopup (probably other classes too) use the same id for their sub-divs, those are:

popup_GroupDiv
popup_contentDiv
popup_close
popup_FrameDecorationDiv_1
popup_FrameDecorationDiv_2
popup_FrameDecorationDiv_3
popup_FrameDecorationDiv_4

id has to be unique in a document:  http://www.w3.org/TR/html401/struct/global.html#h-7.5.2 so i set it to priority:major

I'm shure they should be class="...". Then one could give them usefull css values, e.g. see:  http://trac.osgeo.org/openlayers/ticket/3192#comment:3

Change History

in reply to: ↑ description   Changed 2 years ago by pebXX2346

Replying to pebXX2346:

Addendum

div-ids are set in 'Popup/Framed.js' there is a reference to blocks, blocks are defined in 'Popup/FramedCloud.js'.

Proposal: add a (html)class (olPopup_FrameDecorationDiv_top|left|bottom...) to the block definitions and use that in Framed.js where the divs are created.

  Changed 2 years ago by pebXX2346

  • component changed from general to Popup.Framed
Note: See TracTickets for help on using tickets.