Ticket #3243 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

externalGraphic rendering broken on Android 2.1

Reported by: ahocevar Owned by: crschmidt
Priority: minor Milestone: 2.11 Release
Component: Renderer.Canvas Version: SVN
Keywords: Cc:
State: Commit

Description

Looking at http://openlayers.org/dev/examples/vector-features.html (as well as other examples with external graphics, especially the mobile-jq.htm and mobile-sencha.html ones), we can see that both scale and position of externalGraphic styled features are incorrect when viewed with the Android 2.1 default browser.

For the 2.11 release, if we cannot fix this issue, I think it would be nice to make the mobile-jq and mobile-sencha examples use a simple vector symbol instead of an externalGraphic, at least if we detect that the OS is Android 2.1.

Attachments

openlayers-3243.patch Download (1.5 KB) - added by ahocevar 2 years ago.
openlayers-3243.2.patch Download (1.7 KB) - added by ahocevar 2 years ago.
calculate factor the first time it is used; added comment about 320

Change History

Changed 2 years ago by ahocevar

Changed 2 years ago by ahocevar

Changed 2 years ago by ahocevar

  • state set to Review

Tests still pass. Thanks for any review.

Changed 2 years ago by erilem

Andreas, thanks for the patch, it looks good. Personally I'd make it so the factor value is computed the first time it is needed as opposed to at script evaluation time.

Changed 2 years ago by erilem

  • state changed from Review to Commit

Another comment: before commit could you comment in the code where the 320 value comes from? Thanks.

Changed 2 years ago by ahocevar

calculate factor the first time it is used; added comment about 320

Changed 2 years ago by ahocevar

  • status changed from new to closed
  • resolution set to fixed

(In [11868]) working around drawImage issue on Android 2.1 devices. r=erilem (closes #3243)

Note: See TracTickets for help on using tickets.