Ticket #3235 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Only add features to unrenderedFeatures when drawFeature returns false

Reported by: ahocevar Owned by: crschmidt
Priority: minor Milestone: 2.11 Release
Component: Layer.Vector Version: 2.10
Keywords: Cc:
State: Commit

Description

Renderer::drawFeature returns undefined for features without a geometry, and false for features that were not rendered. Renderer.SVG::drawFeature returns null for features that were drawn incompletely (i.e. clipped because the extent exceeds the coordinate range). But Layer.Vector adds features to the unrenderedFeatures array for every falsish return from Renderer::drawFeature. Instead, it should only add features where drawFeature returns false or null. When we get rid of Renderer.SVG, we only need to check for false.

Attachments

openlayers-3235.patch Download (0.6 KB) - added by ahocevar 2 years ago.

Change History

Changed 2 years ago by ahocevar

follow-up: ↓ 2   Changed 2 years ago by ahocevar

  • state set to Review

All tests pass (except Control.Measure, but they also fail without the patch). Thanks for any review.

in reply to: ↑ 1   Changed 2 years ago by erilem

Replying to ahocevar:

All tests pass (except Control.Measure, but they also fail without the patch). Thanks for any review.

We've got timing issues with the Control.Measure tests. They should eventually pass if you run them multiple times.

  Changed 2 years ago by erilem

  • state changed from Review to Commit

Thanks Andreas. Please commit.

  Changed 2 years ago by ahocevar

  • status changed from new to closed
  • resolution set to fixed

(In [11853]) only add features to the unrendererdFeatures array when they were not drawn due to lack of geometry. r=erilem (closes #3235)"

Note: See TracTickets for help on using tickets.