Missing return value in the Renderer.Canvas.drawFeature() method

[vog]

The attached patch provides a return value for the Renderer.Canvas.drawFeature() method. This is expected by the vector layer in order to determine whether the feature has or hasn't been rendered.

The patch is fairly simple, it always returns true. That way, the features won't be added to the "unrenderedFeatures" array of the vector layer.

[vog]

provide return value for Renderer.Canvas.drawFeature()

[tschaub]

This is a fairly major bug. It means that we're unnecessarily redrawing every feature with every call to moveTo (since we iterate through all unrenderedFeatures there). There is also this weird bit about returning undefined if no geometry and false if not rendered. I don't see where the difference is used, but I think it makes sense to follow suit here as well. If the difference is really not needed, we should do a strict === check for false before adding to the unrendered features object.

[tschaub]

return true if feature is drawn

[tschaub]

(In [11851]) Making it so the canvas renderer returns true after rendering a feature. This saves an extra draw for every moveTo. p=vog,me r=me (closes #3225)

[ahocevar]

r11851 results in no features being drawn at all in the vector-features-with-test.html example.

[ahocevar]

Now tests pass and examples work again. Thanks for any review.

[tschaub]

Rather than add a property which may be used for other purposes, I think it makes sense to only keep track of what we need to know. Since the renderer doesn't lock itself (something we should revisit), it gets screwed up when there is a pending redraw and the last drawn feature in a batch has no geometry (this is the case that failed with r11851).

So, it makes more sense to me to keep track of whether there is a pending redraw. Then, in drawFeature, if rendered is false but pendingRedraw is true, we call redraw. This saves us from calling redraw whenever a feature with no geometry is added to the layer.

[tschaub]

keep track of pending redraws

[tschaub]

With the latest patch, the new tests pass and the above mentioned example works.

[ahocevar]

Great improvement Tim, and thanks for the tests. Please commit.

[tschaub]

(In [11860]) Making the canvas renderer keep track of a pending redraw. With this change we properly redraw even if the last feature in a batch has no geometry. p=me,ahocevar r=ahocevar (closes #3225)