Ticket #3215 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Cleanup mouse event on touch devices

Reported by: sbrunner Owned by: sbrunner
Priority: minor Milestone: 2.11 Release
Component: Handler.Point Version: 2.10
Keywords: patch, mobile Cc:
State: Commit

Description

Tested on Android

Attachments

cleanup.patch Download (1.4 KB) - added by sbrunner 2 years ago.
cleanup.2.patch Download (4.6 KB) - added by erilem 2 years ago.
3215.patch Download (4.6 KB) - added by sbrunner 2 years ago.
Implement Tim solution

Change History

Changed 2 years ago by sbrunner

Changed 2 years ago by erilem

Changed 2 years ago by erilem

  • status changed from new to closed
  • resolution set to invalid

After discussing with Stéphane it turns out that our patches are incorrect. Unregistering listeners in touchstart and setting a flag to avoid unregistering them again is not a good solution, because our listeners will get registered again if the control is deactivated and re-activated, and the handler won't unregister them again (the touch flag is set).

The bad news is that the Click and Drag handlers suffer the same.

Changed 2 years ago by erilem

  • status changed from closed to reopened
  • resolution invalid deleted

Changed 2 years ago by erilem

  • owner changed from tschaub to sbrunner
  • status changed from reopened to new

Changed 2 years ago by sbrunner

Implement Tim solution

Changed 2 years ago by sbrunner

  • state set to Review

Changed 2 years ago by erilem

  • state changed from Review to Commit

Changed 2 years ago by sbrunner

  • status changed from new to closed
  • resolution set to fixed

(In [11827]) Cleanup mouse event on touch devices, r=erilem (closes #3215)

Note: See TracTickets for help on using tickets.