Ticket #3198 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

Handler.Box: Do not clean the box to be deactivate.

Reported by: jorix Owned by:
Priority: minor Milestone: 2.11 Release
Component: Handler.Box Version: SVN
Keywords: Cc:
State: Review

Description

This bug is easy to verify using http://openlayers.org/dev/examples/navtoolbar.html:

  • Select "ZoomBox"
  • Start a drag
  • Move the cursor over "Navigation" button.
  • Release the mouse and press and "Navigation" button.
  • Oops! the rectangle does not disappear.

This bug is related with #3193

Attachments

handler.box-3198 Download (0.6 KB) - added by jorix 2 years ago.
handler.box-3198.2.patch Download (0.6 KB) - added by jorix 2 years ago.

Change History

Changed 2 years ago by jorix

  Changed 2 years ago by jorix

  • state set to Review

Please review.

follow-up: ↓ 3   Changed 2 years ago by ahocevar

@jorix: can you please also try if configuring the Navigation control with documentDrag: true fixes the issue (without your patch applied)? Thanks.

in reply to: ↑ 2   Changed 2 years ago by jorix

Replying to ahocevar:

@jorix: can you please also try if configuring the Navigation control with documentDrag: true fixes the issue (without your patch applied)? Thanks.

It does not work, using OpenLayers.Control.Navigation.documentDrag: true also fails.

follow-up: ↓ 5   Changed 2 years ago by ahocevar

  • state changed from Review to Needs More Work

Handler.Box tests fail with this patch applied.

Changed 2 years ago by jorix

in reply to: ↑ 4   Changed 2 years ago by jorix

  • state changed from Needs More Work to Review

Replying to ahocevar:

Handler.Box tests fail with this patch applied.

Sorry! I thought I had passed tests for this patch, but it was another patch that I tested.

With the new attachment:handler.box-3198.2.patch Download all tests (controls and handlers) are working properly.

Now tested on Chrome-10 and IE8

  Changed 2 years ago by ahocevar

  • status changed from new to closed
  • resolution set to fixed

(In [11729]) removing box when deactivating the handler. p=jorix, r=me (closes #3198)

Note: See TracTickets for help on using tickets.