Ticket #3195 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

Zoom while drawing: Strange behavior of the cursor.

Reported by: jorix Owned by: erilem
Priority: major Milestone: 2.11 Release
Component: Handler.Path Version: SVN
Keywords: Cc:
State: Review

Description

Using mobile devices (small screens) is very useful to zoom while drawing.

When zoom (in or out) the insertion point is separated from the drawing if you have previously made ​​a pan.

Tested on iPad.

Attachments

3195.patch Download (2.0 KB) - added by jorix 2 years ago.
3195.2.patch Download (2.9 KB) - added by jorix 2 years ago.

Change History

Changed 2 years ago by jorix

  Changed 2 years ago by jorix

  • state set to Review

In Handler.Path.addPoint this.point is removed but not added, this was the problem. A single line!

Tests are added.

  Changed 2 years ago by erilem

  • owner changed from tschaub to erilem

follow-ups: ↓ 4 ↓ 5   Changed 2 years ago by erilem

  • priority changed from minor to major

Very good patch! One thing though: Measure test_cancel fails with your patch applied:

test_cancel  fail 1 ok 3
ok calling cancel before drawing works
ok control remains active after cancel
fail feature persists. eq: values differ: got 2, but expected 1
ok feature is gone after cancel

It would be great if you could investigate this problem.

in reply to: ↑ 3   Changed 2 years ago by jorix

Replying to erilem:

Very good patch! One thing though: Measure test_cancel fails with your patch applied: {{{ test_cancel fail 1 ok 3 ok calling cancel before drawing works ok control remains active after cancel fail feature persists. eq: values differ: got 2, but expected 1 ok feature is gone after cancel }}} It would be great if you could investigate this problem.

The cause of the problem surprised me.

This afternoon I looked at it test controls.

Changed 2 years ago by jorix

in reply to: ↑ 3   Changed 2 years ago by jorix

Replying to erilem:

It would be great if you could investigate this problem.

I've done several tests with the examples/measure.html (yesterday and today) and everything goes correctly (but see NOTE).

In tests/control/measure.html missing trigger("dblclick", 10, 10); but this before "pan while dragging" and did not affect the test because the bug r8831 is before this test r9225.

So, in attachment:3195.2.patch Download I changed tests/measure.html

Tested in: IE8, EI6, Chrome-10, Safari. But in FF3.6.15 everything works except handler/box.html (fails with or without patch)

NOTE: Double click sometimes fails in IE8 without <!DOCTYPE > (try lines with many points or polygons). For example fails in examples/measure.html (see description of this bug in #3194)

Please review.

  Changed 2 years ago by jorix

NOTE: Before #3195 tests/measure.html worked also when persist: false, so it was not a proper test.

  Changed 2 years ago by jorix

I neglected to say that I passed the tests for all controls and handlers.

  Changed 2 years ago by erilem

  • status changed from new to closed
  • resolution set to fixed

(In [11836]) when drawing make sure the point follow the cursor, even after zooming in or out, p=jorix, r=me (closes #3195)

Note: See TracTickets for help on using tickets.