Problem with double click to finish a drawing using IE6

[jorix]

In IE6 now it is very difficult to finish a drawing with double click (measure.html and draw-feature.html)

Pressing a second double click without moving the mouse it works (this seems to always works)

Test with Path and Polygons (XP SP2 with IE6)

[jorix]

Double click sometimes fails in IE8 without <!DOCTYPE > (try lines with many points or polygons). For example fails in examples/measure.html

[tschaub]

I've seen this problem in previous releases. Is it noticeably worse in the trunk than in 2.10?

[jorix]

Replying to tschaub:

I've seen this problem in previous releases. Is it noticeably worse in the trunk than in 2.10?

Yes and not. I think now is due to another problem.

I think when js works fairly between click and click on the IE (without !DOCTYPE or IE6) has trouble detecting the double click. Now it occurs again in handler.drag with further improvement: pan while dragging.

So far I have not researched enough to make more assertions.

[erilem]

Replying to jorix:

Replying to tschaub:

I've seen this problem in previous releases. Is it noticeably worse in the trunk than in 2.10?

Yes and not. I think now is due to another problem. I think when js works fairly between click and click on the IE (without !DOCTYPE or IE6) has trouble detecting the double click. Now it occurs again in handler.drag with further improvement: pan while dragging.

Hi Xavier. I must confess that I'm having a hard time understanding you here. I'd appreciate you rephrasing a bit. Thanks.

[jorix]

Replying to erilem:

Hi Xavier. I must confess that I'm having a hard time understanding you here. I'd appreciate you rephrasing a bit. Thanks.

Hi Eric, sorry for my English.

It is a problem with IE. In my response to Tim just talk about my feelings, I have worked long enough this problem (in measure)

I think the execution of a lot of javascript code between two consecutive clicks prevents IE detect a double click.

Now "handler.path", "handler.Polygon" run a lot of code between click and click to enable a drag.

I have no evidence of my assertions, and would love to be wrong.

[jorix]

Replying to jorix:

oops!

Now it occurs again in handler.drag with further improvement: pan while dragging.

Now it occurs again in Handler.Path & Polygon with further improvement: pan while drawing.

[erilem]

Hi Xavier.

First of all, I don't understand what you mean by "with further improvement: pan while drawing" above. Do you mean the problem is more easily reproducible in trunk than in 2.10 because of the "pan draw" patch?

Now some information:

I could effectively reproduce the issue in IE8 using the measure.html example. I'm also observing that the size of the map div changes while drawing! I'd tend to think the "double-click to finalize drawing" issue is related to that.

And actually, you don't have to activate drawing to see the map div changing in size: select "navigate", and do sequences like this: "pan the map, leave the map div, re-enter the map div, ...". You should see the map shrinking and enlarging.

By adding <!DOCTYPE> to the page the problems effectively go away.

The map changing in size on sequences like "leaving the map div, entering the map div, panning, ..." can also be observed on other examples, draw-feature.html for example.

At this point I don't know whether this is a regression.

[jorix]

Replying to erilem:

Hi Xavier. First of all, I don't understand what you mean by "with further improvement: pan while drawing" above. Do you mean the problem is more easily reproducible in trunk than in 2.10 because of the "pan draw" patch?

Yes

I tested doubleclick with IE6 using "examples/draw-feature.html" with "trunk" and "2.10". With "2.10" it costs to make a double click, but in the "trunk" I have not done any double-click (path and polygons)

Regarding IE8, rarely fails and are more subjective differences in misbehavior double click using "trunk" or "2.10"

Now some information: I could effectively reproduce the issue in IE8 using the measure.html example. I'm also observing that the size of the map div changes while drawing! I'd tend to think the "double-click to finalize drawing" issue is related to that. And actually, you don't have to activate drawing to see the map div changing in size: select "navigate", and do sequences like this: "pan the map, leave the map div, re-enter the map div, ...". You should see the map shrinking and enlarging. By adding <!DOCTYPE> to the page the problems effectively go away. The map changing in size on sequences like "leaving the map div, entering the map div, panning, ..." can also be observed on other examples, draw-feature.html for example.

Yes, I know this effect. This effect disappears using <div id="map" style="border: 0 solid #000" class="smallmap"></div> or using <!DOCTYPE>, even using IE6. But the problem of double click using IE6 on the trunk does not disappear.

At this point I don't know whether this is a regression.

Ok, IE6 is increasingly residual.

[jorix]

This patch requires changes in the tests (need to work on the test)

[jorix]

With IE6 the problem is that pressing double click to finish drawing the sequence of events is the following: mousedown, mouseup and mouseup!. Yes disappears second mousedown and dblclick.

The patch proposes emulate the double click, like the double tap is emulated.

This simplifies the Measure control no longer need timer :-)

All I have done testing with IE6, IE8 and FF3.16, and working correctly :-)

But, logically a lot of tests stop working :-((
Before further work on this I thought it appropriate to present the operational side of the patch.

[leole]

Thanks. That patch works perfectly within my application using IE8 and fixes the problem with the double click there. It works also correctly in my FFOX 10.0. If you need testing, just contact me

[jorix]

Replying to leole:

Thanks. That patch works perfectly within my application using IE8 and fixes the problem with the double click there. It works also correctly in my FFOX 10.0. If you need testing, just contact me

Thanks :)

I like the approach of this patch as it cleans controls with problems in the double-click as Measure.

But I do not know if OpenLayers team shares my point of view, I'm afraid not. Is for this reason I have not worked in the tests for now.