Ticket #3110 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

the Grid tests produce js errors

Reported by: erilem Owned by: erilem
Priority: major Milestone: 2.11 Release
Component: Layer.Grid Version: 2.10
Keywords: mobile Cc:
State: Complete

Description

With moveGriddedTiles now executed after a timeout our tests produce js errors because the grid layer is already destroyed and moveGriddedTiles is actually called. This revealed a bug the Grid.js code I think - the timer should be cleared in destroy.

Attachments

patch-3110-A0.diff Download (2.5 KB) - added by erilem 2 years ago.

Change History

Changed 2 years ago by erilem

  • keywords mobile added

Changed 2 years ago by erilem

  • owner changed from elemoine to erilem

Taking this on just now...

Changed 2 years ago by erilem

Changed 2 years ago by erilem

  • state set to Review

Tests pass, and no longer cause js errors in Grid.html and Map.html.

Changed 2 years ago by crschmidt

  • state changed from Review to Commit

Tests pass, and behavior seems solid. Please commit.

Changed 2 years ago by erilem

  • status changed from new to closed
  • resolution set to fixed

(In [11482]) the grid layer needs to clear its tile loading timeout when it's removed from the map, or moveGriddedTiles can be called with this.map set to null, r=crschmidt (closes #3110)

Changed 2 years ago by erilem

  • state changed from Commit to Complete
Note: See TracTickets for help on using tickets.