Ticket #3032 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

pull specific filterToParams method out of HTTP protocol

Reported by: tschaub Owned by:
Priority: minor Milestone: 2.11 Release
Component: Protocol.HTTP Version: 2.10
Keywords: Cc:
State: Commit

Description

The filterToParams method on the HTTP protocol is specific to MapFish (as far as I know). We should make it obvious that it can be configured with an alternate method. In addition, the same method should be available to other protocols (e.g #2956).

Attachments

3032.patch Download (38.0 KB) - added by tschaub 2 years ago.
pull out MapFish filterToParams serializer
3032.2.patch Download (26.0 KB) - added by crschmidt 2 years ago.
3032.3.patch Download (38.0 KB) - added by crschmidt 2 years ago.
3032.4.patch Download (38.0 KB) - added by tschaub 2 years ago.
extracting the simple filter serializer

Change History

Changed 2 years ago by tschaub

pull out MapFish filterToParams serializer

Changed 2 years ago by tschaub

  • state set to Review

Tests pass. With this, the original behavior of the HTTP protocol is preserved. It also allows custom builds to exclude the MapFishFilterSerializer and app devs to provide their own filterToParams method.

Thanks for any review.

Changed 2 years ago by crschmidt

This looks good. The naming is not that important. After all, we're still making people use OpenLayers.LonLat :) maybe someday us server devs can sit down and give this filter type a name, but until then, let's roll with this.

Attaching a new patch to fix conflicts, but other than that, this looks solid, tests pass, please commit.

Changed 2 years ago by crschmidt

Changed 2 years ago by crschmidt

Changed 2 years ago by crschmidt

  • state changed from Review to Commit

Ignore the .2. patch, grab the .3. :)

Changed 2 years ago by tschaub

extracting the simple filter serializer

Changed 2 years ago by tschaub

Given that this is used in more than one place, I think we agree a more general name makes sense. I've updated the patch to name this "SimpleFilterSerializer."

I hope this meets with approval.

Changed 2 years ago by tschaub

  • status changed from new to closed
  • resolution set to fixed

(In [11673]) Adding a filterToParams method on the HTTP protocol. This allows you to specify how a filter is serialized in HTTP feature requests (using CQL for example). By default, we use the OpenLayers.Protocol.simpleFilterSerializer method. r=crschmidt (closes #3032)

Note: See TracTickets for help on using tickets.