Ticket #3020 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

option to disable animate zooming

Reported by: ahocevar Owned by:
Priority: minor Milestone: 2.11 Release
Component: Layer.Google.v3 Version: 2.10
Keywords: Cc:
State: Complete

Description

The GMaps v3 API does not support it, but we can do it by making the layer temporarily invisible.

Attachments

openlayers-3020.patch Download (2.5 KB) - added by ahocevar 2 years ago.
openlayers-3020.2.patch Download (2.8 KB) - added by ahocevar 2 years ago.
changed as suggested by bartvde

Change History

Changed 2 years ago by ahocevar

Changed 2 years ago by bartvde

Andreas, looks good, would it not make more sense in the example when switching base layers to apply the current setting to the base layer selected? I find it a bit strange that when I change the baselayer that my "application" option for Animated zoom changes.

Changed 2 years ago by bartvde

Another thing that comes to my mind, would it not make more sense to use transitionEffect as the option name? With a default of resize? That way it is closer to what OL currently uses. Setting it to null would remove the transitionEffect. What do you think?

Changed 2 years ago by ahocevar

changed as suggested by bartvde

Changed 2 years ago by ahocevar

I only changed the example, because the same option is also called animationEnabled in Layer.VirtualEarth. And transitionEffect, in my opinion, is something that OpenLayers does, not an external API.

Changed 2 years ago by bartvde

  • state changed from Review to Commit

Thanks for the feedback, I agree, please commit.

Changed 2 years ago by ahocevar

Thanks @bartvde for the comments and review. In w/ r11047

Changed 2 years ago by fredj

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed
Note: See TracTickets for help on using tickets.