Ticket #3011 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Support tileOrigin for all Grid layers.

Reported by: tschaub Owned by: elemoine
Priority: minor Milestone: 2.11 Release
Component: Layer.Grid Version: 2.10
Keywords: Cc:
State:

Description

In r11002, support was added for a tileExtent property. This was a quick fix to make gridded layers work with cached tile sets with a lattice that doesn't align with the layer's maxExtent property. However, the "bottom left" assumption is still baked in (the lattice is aligned with the bottom left of the tileExtent or maxExtent). This still doesn't work for all tile caches.

The proper way to support tile caches with our gridded layers is to support a tileOrigin property. It also makes sense to pull out the "bottom left" assumption into a property that other layers can override.

To avoid overlapping property proliferation, and because the behavior with tileExtent is not really adequate (we also still request tiles outside the tileExtent), I'd like to remove that property and only add tileOrigin to the API.

Attachments

3011.patch Download (10.4 KB) - added by tschaub 2 years ago.
support tileOrigin for Grid layers

Change History

Changed 2 years ago by tschaub

support tileOrigin for Grid layers

Changed 2 years ago by ahocevar

I am in favor of this change. In case you meant to set this ticket's state to "Review", I'd set it "Commit" now.

Changed 2 years ago by tschaub

  • state set to Commit

Great, thanks. I did mean to set it to Review status. I wanted to get feedback about how it worked in a few environments first. Got that feedback, and I think it is working as expected. Thanks for the review.

Changed 2 years ago by tschaub

  • status changed from new to closed
  • state Commit deleted
  • resolution set to fixed

Closed with r11033.

Note: See TracTickets for help on using tickets.