Ticket #2996 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

make click handler work with touch events

Reported by: erilem Owned by: tschaub
Priority: major Milestone: 2.11 Release
Component: Handler.Click Version: 2.10
Keywords: mobile Cc: courriel@…
State: Complete

Description

In addition to mousedown and mouseup make the click handler work with touchstart and touchend.

Attachments

patch-2996-A0.diff Download (9.0 KB) - added by erilem 2 years ago.

Change History

Changed 2 years ago by erilem

  Changed 2 years ago by erilem

See the patch-2996-A0.diff Download patch. With this patch the Click handler can generate click and dblclick events on touch and double touch.

This patch depends on the patch attached to #2995, which adds touch events to the Events.BROWSER_EVENTS array.

  Changed 2 years ago by sbrunner

  • cc courriel@… added

  Changed 2 years ago by bartvde

Reviewing this one now.

  Changed 2 years ago by erilem

  • state set to Review

follow-up: ↓ 6   Changed 2 years ago by bartvde

  • state changed from Review to Commit

Hi Eric, this looks good to me, nice work, 3 small questions/remarks:

Should we not use lastTouches instead of lasttouches? Should we not document "last" at the Class as a property? Doc typo: a empty touches property --> should be an empty touches property

in reply to: ↑ 5   Changed 2 years ago by erilem

Replying to bartvde:

Hi Eric, this looks good to me, nice work, 3 small questions/remarks: Should we not use lastTouches instead of lasttouches? Should we not document "last" at the Class as a property? Doc typo: a empty touches property --> should be an empty touches property

Thanks. I agree with your three points, and will do the corresponding changes before commit.

  Changed 2 years ago by erilem

  • status changed from new to closed
  • resolution set to fixed

In with [11201].

  Changed 2 years ago by erilem

  • keywords mobile added

  Changed 2 years ago by fredj

  • state changed from Commit to Complete
Note: See TracTickets for help on using tickets.