Ticket #2994 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

some test_Date_parse tests fail in Chrome 8 and 9

Reported by: erilem Owned by: tschaub
Priority: minor Milestone: 2.11 Release
Component: BaseTypes Version: 2.10
Keywords: Cc:
State:

Description

Since r10630 (#2778 add ISO date parsing and toISOString for dates) some test_Date_parse tests fail in Chrome 8 and 9.

A time-related KML test also fails: 

test_extractTracks fail 1 ok 11
...
fail correct time for fifth feature. eq: values differ: got 1272719115000, but expected 1272736815000

Attachments

2994.patch Download (4.0 KB) - added by tschaub 2 years ago.
consistent date parsing

Change History

Changed 2 years ago by tschaub

  • owner set to tschaub
  • status changed from new to assigned
  • component changed from tests to BaseTypes
  • type changed from feature to bug

Chrome decides that the datestring is in the local timezone if not otherwise specified. Firefox decides that the datestring is in UTC if not otherwise specified (WebKit has not yet weighed in). So, using the native Date.parse we get different behavior across implementations. To get consistency, we won't use the native Date.parse.

Changed 2 years ago by tschaub

consistent date parsing

Changed 2 years ago by tschaub

  • state set to Review

Tests now pass in Chrome, Firefox, and IE6.

Changed 2 years ago by crschmidt

  • state changed from Review to Commit

This seems totally reasonable.

Changed 2 years ago by tschaub

  • status changed from assigned to closed
  • state Commit deleted
  • resolution set to fixed

In w/ r11281.

Note: See TracTickets for help on using tickets.