box handler cancels click

[pgiraud]

Since the  revision 10871, the box handler prevents the click events from being triggered.

As said almost everywhere "The click event occurs when the pointing device button is clicked over an element. A click is defined as a mousedown and mouseup over the same screen location.". This means that "mousedown" and "mouseup" have to occur on the same element.

In our case, when "mousedown" is triggered, the box handler creates a new div element which is appended under the mouse cursor. When "mouseup" is triggered, the event target is not the same. The "click" event is not triggered.

Before the changeset, the box was positioned with a tiny offset. Now that positioning is better, the box div is exactly under the mouse.

A straight way to solve the issue is to position the box under the cursor only once the latter is actually moved.

Attached is a patch, and an example to manually test the issue.

[pgiraud]

patch for Handler.Box

[pgiraud]

Manual test example

[erilem]

Confirming that tests pass in Chrome 8 and FireFox 3. Good catch. Good patch. Please commit.

[pgiraud]

Fixed in r10996.

[pgiraud]

There's a regression in r11749.

[erilem]

Thanks for the patch Pierre. It looks good. Please commit.

[pgiraud]

(In [11923]) Don't put the box under the cursor until the mouse moved, prevent errors with the GetFeature and click events. I also removed the no longer valid (and failing) tests. r=elemoine, (Closes #2993)