Popup appears automatically when using Google Maps API v3

[vladimirc]

When a Google Maps API V3 map is loaded a popup appears containing data and imagery credits and a close button.

The popup can be closed but it keeps appearing again every time you click, pan or zoom the map.

[vladimirc]

Screenshot Google API v3 Popup

[erilem]

See < http://getsatisfaction.com/opengeo/topics/how_to_get_rid_of_goggle_layers_map_data_windows> and [10974].

[ahocevar]

I did some investigation on this, and apparently r10974 is a workaround, not a fix. Fact is that this popup is not something that Google displays. It is that our logic for moving attribution and logo to the container does not work any more, because the popup was added as hidden element as last child of the google map div, and we made it visible by messing with style.display.

The attached patch moves this hidden element (if available, i.e. if using a new v3 api that has it) to the container without modifying it. The copyright is also no longer switched between hidden and visible, because we move it to an invisible position (-9999px) anyway.

Another positive side effect of this patch is that the PoweredBy logo is clickable again - this was also broken because of this new hidden popup.

Because Google now also sets the position of the copyright and logo using element styles, we need to use !important in our css. So this patch also fixes the css, and modifies google.css to use the correct original positions for v3.

Tests still pass. Thanks for any review.

[ahocevar]

Please disregard the comment about no longer switching the copyright between hidden and visible - I decided to continue doing so. Better safe than sorry, and eliminates the chance of a regression.

[ahocevar]

updating form v3.2 to v3.3

[bartvde]

Your patch looks good to me Andreas, please commit. Google V3 Layer tests also pass on IE8 and Firefox 3.6.

[ahocevar]

Thanks @bartvde for the review. In w/ r11042.

[anrikun]

Since today, the popup has started to show up again. And copyright is displayed twice.

[anrikun]

Adding this to CSS hides popup and 2nd copyright:

div.olLayerGoogleCopyright,
div.olLayerGooglePoweredBy
{
  display: none !important;
}

but Google links are still not clickable.

[bociek]

I confirm that. As for now i've just switched to v3.6, thats "solves" that issue.

Doesn't anrikun's CSS solution break Terms Of Use?

[anrikun]

My solution is just a temporary hack that prevents popup from showing up, but not a viable solution as Google links are not clickable. Google copyright and notices are still displayed though, but the fact that they are not clickable might indeed break TOS, I don't know.

[ahocevar]

Fixed with  https://github.com/openlayers/openlayers/commit/b17c7b69f25ce0ddbaf720f91b7d48328b005831 - add documentation on the supported API version, so people don't use versions > 3.6.

[bociek]

As for now, google forces use of 3.7, even when requested 3.6, so problem reappears.

[ahocevar]

Fixed with  https://github.com/openlayers/openlayers/commit/92f04a7a4277a6c818ef2d40a2856910ed72d3d6; duplicate of #3614