allow custom jsfiles array

[erilem]

To reduce the loading time of the lib during development and testing it would be good to be able to provide a custom jsfiles array.

Example :

    <script type="text/javascript">
        window.__OpenLayersJsFiles = new Array(
                "OpenLayers/Util.js",
                "OpenLayers/BaseTypes.js"
        );
    </script>
    <script src="../lib/OpenLayers.js"></script>

In this example the OpenLayers.js script will load two additional scripts only, Util.js and BaseTypes.js.

Patch to come.

[erilem]

See patch-2947-A0.diff . Tests pass in FF3 and Chrome7.

[tschaub]

Why not stay in the OpenLayers namespace?

I don't think it's too onerous for tests to do something like this before including the loader script:

var OpenLayers = [
    "OpenLayers/Util.js",
    "OpenLayers/BaseType.js"
];

Then the OpenLayers.js loader could check for this array, set jsFiles, and redefine the OpenLayers object.

[tschaub]

By the way, I think this is a great idea for speeding up test/dev example times.

[erilem]

Good suggestion Tim! See patch-2947-A1.diff .

[tschaub]

Thanks for making the change Eric. This is looking good. Your patch is missing the OpenLayersJsFiles.html test page. Did you forget to add it?

[erilem]

Replying to tschaub:

Thanks for making the change Eric. This is looking good. Your patch is missing the OpenLayersJsFiles.html test page. Did you forget to add it?

I did. See patch-2947-A2.diff .

I've been thinking... Wouldn't it actually be better (more natural) to be able to do:

    <script type="text/javascript" src="../lib/OpenLayers.js?noautoload=true></script>
    <script type="text/javascript" src="../lib/OpenLayers/Util.js></script>

instead of

    <script type="text/javascript">
    var OpenLayers = [
        "OpenLayers/Util.js"
    ];
    </script>
    <script type="text/javascript" src="../lib/OpenLayers.js></script>

With my patch the following can be done:

    <script type="text/javascript">
    var OpenLayers = [];
    </script>
    <script type="text/javascript" src="../lib/OpenLayers.js></script>
    <script type="text/javascript" src="../lib/OpenLayers/Util.js></script>

but this isn't user-friendly.

Tell me what you think. I'm happy to commit the current patch, or to provide a new patch for the noautoload solution.

[tschaub]

I think what you're proposing with the "noautoload" parameter would be most trivially accomplished by loading the SingleFile.js instead of OpenLayers.js (see r10977).

The only hassle with this is typing all the extra script tags. I think the tidiest way to avoid this hassle is to allow typing an array instead.

Here are a few variations that accomplish the same:

<script>
    var OpenLayers = ["OpenLayers/Util.js", "OpenLayers/foo.js"];
</script>
<script src="lib/OpenLayers.js"></script>

or

<script src="lib/OpenLayers.js">
    // here the OpenLayers.js script can eval the innerHTML 
    // of the last script in the doc
    var OpenLayers = ["OpenLayers/Util.js", "OpenLayers/foo.js];
</script>

or

<!-- here OpenLayers.js splits and trims the innerHTML to get the file list -->
<script src="lib/OpenLayers.js">
    OpenLayers/Util.js
    OpenLayers/foo.js
</script>

or

<script src="lib/OpenLayers.js?files=OpenLayers%2FUtil.js,OpenLayers%2Ffoo.js"></script>

I think we'd agree this last one is ugly to type. The first is simplest to implement. The others are somewhat forced. And the whole thing is really just for us internally (tests and examples) - I don't think we should try to get too clever.

[erilem]

Thanks Tim. Please change the ticket state to Commit if you agree with patch-2947-A2.diff .

[tschaub]

selective loading

[tschaub]

Patch updated so it applies at r11155. I modified the Util.html tests to confirm it works. Works in IE6 and FF3. Thanks for the work. Please commit.

[erilem]

In with [11136].

[erilem]

Tim, I just realized that tests/OpenLayersJsFiles.html isn't in your patch. Can I just the file I had in my patch, or have you made changes to that file as well?

[tschaub]

Sorry about that Eric. I think you can just pull in the OpenLayersJsFiles test from your patch.

[erilem]

Replying to tschaub:

Sorry about that Eric. I think you can just pull in the OpenLayersJsFiles test from your patch.

I did during the code sprint. See [11151].