Ticket #2889 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

Path handler: create APIFunction from dblclick internals

Reported by: bartvde Owned by: tschaub
Priority: minor Milestone: 2.11 Release
Component: Handler.Path Version: 2.10
Keywords: Cc:
State: Complete

Description

If someone wants to write a tool (button) which finishes the geometry instead of using double click, e.g. since they are working on a tablet device, they now have to use an internal method of OpenLayers.Handler.Path with a fake event object.

I propose to move the internals of the dblclick handler into a new APIMethod which can also be called externally, and then use that method in the dblclick handler.

Attachments

ol-2889.patch Download (1.2 KB) - added by bartvde 3 years ago.

Change History

Changed 3 years ago by bartvde

Changed 3 years ago by bartvde

  • state set to Review

Please review.

Changed 3 years ago by erilem

  • state changed from Review to Commit

It looks good. Please commit if you can confirm that Handler.Path tests still pass.

Changed 3 years ago by erilem

Fixed with r10847.

Changed 3 years ago by bartvde

Thanks erilem, I did not know the closes hook is still down :-)

Changed 3 years ago by bartvde

  • status changed from new to closed
  • resolution set to fixed

Changed 3 years ago by bartvde

  • state changed from Commit to Complete
Note: See TracTickets for help on using tickets.