Ticket #2855 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

"this.div.children is null" with OpenLayers.Control.Panel

Reported by: fvanderbiest Owned by:
Priority: major Milestone: 2.11 Release
Component: Control.Panel Version: SVN
Keywords: Cc:
State: Commit

Description

This happens (at least) with FF3 when redraw method is called and this.div has no children

Attachments

ol_2855_A0.diff Download (0.5 KB) - added by fvanderbiest 3 years ago.
ol_2855_A1.diff Download (0.7 KB) - added by fvanderbiest 3 years ago.

Change History

Changed 3 years ago by fvanderbiest

Changed 3 years ago by fvanderbiest

  • state set to Review

Tests pass with FF3.6 IE8 Chromium6.

Changed 3 years ago by fvanderbiest

With elemoine, we found out that document.createElement('div').children is an empty array in FF 3.6 while it is undefined with FF 3.0.x

This completely explains the current problem.

Changed 3 years ago by fvanderbiest

In fact, the DOM "children" property should never be used because it is not supported by FF3.0, see for instance  http://www.quirksmode.org/dom/w3c_core.html#t71

A new patch is attached. Tests pass with FF3.0 FF3.6 IE8 Chromium7.

Changed 3 years ago by fvanderbiest

Changed 3 years ago by erilem

  • state changed from Review to Commit

Changed 3 years ago by erilem

[10665] introduced this regression.

Changed 3 years ago by erilem

  • status changed from new to closed
  • resolution set to fixed

Fixed in r10801.

Note: See TracTickets for help on using tickets.