Ticket #2832 (closed feature: invalid)

Opened 3 years ago

Last modified 3 years ago

Scale control: Sets as deprecated the optional parameter in constructor (thinking 3.0)

Reported by: jorix Owned by:
Priority: minor Milestone: 2.11 Release
Component: Control.Scale Version: 2.10
Keywords: Cc:
State:

Description

In the patch is proposed to overload the first parameter of constructor in order to have two constructors: one with "options" as single parameter and another, deprecated, with three parameters.

The patch includes a specific test.

The tests work well in: FF36, IE8, Chrome6 & Safari5.

Attachments

ControlScale-newConstructor-2832.patch Download (2.9 KB) - added by jorix 3 years ago.

Change History

Changed 3 years ago by jorix

  Changed 3 years ago by jorix

  • state set to Review

in reply to: ↑ description   Changed 3 years ago by jorix

Replying to jorix:

...with three parameters...

ups! is: ...with two parameters ...

Please review, thanks.

follow-up: ↓ 4   Changed 3 years ago by ahocevar

  • status changed from new to closed
  • resolution set to invalid

Adds a lot of code for maintaining backwards compatibility, with no functional improvement.

in reply to: ↑ 3   Changed 3 years ago by jorix

Replying to ahocevar:

Adds a lot of code for maintaining backwards compatibility, with no functional improvement.

I think it may serve to establish a bridge between the current and 3.0 constructors. This could migrate calls to constructor of a single parameter in 2.x, this was the only purpose.

  Changed 3 years ago by jorix

  • state Review deleted
Note: See TracTickets for help on using tickets.