Ticket #2831 (closed feature: wontfix)

Opened 3 years ago

Last modified 3 years ago

Permalink control: Implement methods activate/deactivate.

Reported by: jorix Owned by: crschmidt
Priority: minor Milestone: 2.11 Release
Component: Control.Permalink Version: 2.10
Keywords: Cc:
State:

Description

The attached patch implements the methods activate/deactivate on the control.

The patch includes a specific test.

The tests work well in: FF36, IE8, Chrome6 & Safari5.

Attachments

ControlPermalink-activate-2831.patch Download (5.1 KB) - added by jorix 3 years ago.

Change History

Changed 3 years ago by jorix

follow-up: ↓ 2   Changed 3 years ago by ahocevar

  • status changed from new to closed
  • resolution set to invalid

Why would someone want to deactivate and reactivate a Permalink control? See #2519. The patch adds a lot of code which is not very useful in my opinion (think library size).

in reply to: ↑ 1   Changed 3 years ago by jorix

Replying to ahocevar:

Why would someone want to deactivate and reactivate a Permalink control? See #2519.

Only to clean the scene of the map. My concern is that now activate/deactivate do nothing, but in others controls it act. In what must act and which are not?

The patch adds a lot of code which is not very useful in my opinion (think library size).

Yes in 2.x, much of the additional code is to keep the parameter "element" of the constructor.

follow-up: ↓ 4   Changed 3 years ago by ahocevar

As a rule of thumb, controls that do not create Handler instances do not support activate/deactivate.

in reply to: ↑ 3   Changed 3 years ago by jorix

Replying to ahocevar:

As a rule of thumb, controls that do not create Handler instances do not support activate/deactivate.

Then Panel", "Graticule" and "MousePosition" are exceptions?, hence my confusion comes the #2520 and #2567 tickets were approved.

  Changed 3 years ago by ahocevar

  • status changed from closed to reopened
  • state set to Review
  • resolution invalid deleted

Whatever. Sorry if my closing the ticket was biased. Reopening and setting state back to review.

  Changed 3 years ago by jorix

  • state changed from Review to Needs More Work

"Needs more work" for the same reason that #2822

  Changed 3 years ago by jorix

  • status changed from reopened to closed
  • state Needs More Work deleted
  • resolution set to wontfix

Closed as "wontfix" for the same reason that #2822

Note: See TracTickets for help on using tickets.