filter evaluate method should accept a feature

[tschaub]

Currently, the evaluate method on filters is inconsistent. Comparison filters expect feature attributes (or any other object). Spatial filters expect a feature (as do fid filters). This makes it so logical filters don't work (you can't evaluate a logical filter that contains a spatial filter and a comparison filter).

The evaluate method should accept features.

[tschaub]

evaluate features

[tschaub]

By making comparison filters accept a feature in the evaluate method, we get consistency. Logical filters pass on whatever they get. Comparison filters accept either a feature or a context object for backwards compatibility. Logical filters can now be used with comparison and spatial filters.

Tests pass. Thanks for any review.

[ahocevar]

Good catch. I have no idea how this could remain undiscovered for such a long time. Thanks for the extended test coverage and code optimizations that accompany this patch. Great work - please commit.

[tschaub]

(In [10596]) Making consistent the evaluate method of filters. The evaluate method accepts vector features, making possible logical filters that combine spatial and comparison filters. r=ahocevar (closes #2773)