OpenLayers.Layer.clone() does not clone properties of Object type correctly

[aratcliffe]

When cloning a Vector layer the source layer's protocol and any configured strategies will be copied by reference to the clone object. If the cloned layer's destroy() method is called the shared protocol and strategy objects will be destroyed and the source layer will cease to function.

A possible solution would be to implement a clone() method on both the Protocol and Strategy interfaces and use this method when cloning the layer e.g.

for(var property in source) {

var value = source[property]; if(value !== undefined) {

if(value.clone) {

value = value.clone();

} destination[property] = value;

}

}

[fredj]

No patch, bumping.

[zjames]

patch against [12346]

[zjames]

Attached a patch that resolves the problem but may not be a good approach to the broader problem. Rather than testing for clone methods on contained objects, perhaps Util should have a deep copy function that could be used in place of applyDefaults when cloning.