Ticket #2717 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Control.WMSGetFeatureInfo: double setMap on handler

Reported by: fredj Owned by:
Priority: minor Milestone: 2.10 Release
Component: Control.WMSGetFeatureInfo Version: 2.9
Keywords: Cc:
State: Complete

Description

The WMSGetFeatureInfo redefine the setMap function:

  this.handler.setMap(map);
  OpenLayers.Control.prototype.setMap.apply(this, arguments);

But the parent class already call this.handler.setMap(map): the handler.setMap function is called twice.

Attachments

2717.0.patch Download (0.6 KB) - added by fredj 3 years ago.
remove WMSGetFeatureInfo.setMap, not yet tested

Change History

Changed 3 years ago by fredj

remove WMSGetFeatureInfo.setMap, not yet tested

Changed 3 years ago by fredj

  • state set to Review

tests pass in FF 3.6.6 and Chrome.

The Control/SLDSelect.html tests don't pass but it's not related to this change.

Changed 3 years ago by ahocevar

  • state changed from Review to Commit

Good catch. Please commit if the Control/SLDSelect.html tests also fail without the patch applied.

Changed 3 years ago by fredj

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10437]) remove setMap function from WMSGetFeatureInfo. r=ahocevar (closes #2717)

Note: See TracTickets for help on using tickets.