Renderer and Format.SLD should use fill and stroke unless set to false

[ahocevar]

OpenLayers.Renderer and OpenLayers.Format.SLD currently check for symbolizer.stroke being true, but the API docs for OpenLayers.Feature.Vector.style say:

 * fill - {Boolean} Set to false if no fill is desired.

and

 * stroke - {Boolean} Set to false if no stroke is desired.

The attached patch fixes this behavior. All examples still look right and tests still pass.

[ahocevar]

What I said in the ticket description is not 100% true. Only Renderer does a fill and stroke check. Format.SLD does some ducktyping. With the above patch, we get a consistent behavior.

Thanks for any review!

[tschaub]

This looks good. Assuming tests pass in IE, please commit.

[ahocevar]

r10430 - r=tschaub

[elemoine]

[10430] breaks the SLDSelect.html tests and one of our apps. Reopening, and researching the issue...

[ahocevar]

change the SLDSelect control's default Polygon symbolizer to produce the same result as before

[ahocevar]

The above patch makes the SLDSelect tests pass again. Of course, due do the original issue, the SLD produced by SLDSelect had no stroke, which we can now - according to the docs - achieve by setting stroke to false.

BTW, the inconstency of the behavior that the original patch fixed can be seen by looking at the default Point symbolizer in the SLDSelect control. It also does not define any stroke properties, but the resulting SLD has a stroke.

All tests pass now. Thanks for any review.

[elemoine]

Thanks Andreas.

[ahocevar]

(In [10446]) change the SLDSelect control's default Polygon symbolizer to produce the same result as before r10430. r=elemoine (closes #2712)