give featureId to eraseGeometry

[bartvde]

It would be helpful for some custom renderers (like my own in this particular case) if eraseGeometry was called with the featureId parameter. My DOMElements are created with id = featureId, and this makes is more efficient to look up the element when erasing the geometry.

[bartvde]

If I look at the Canvas renderer, it has the same issue as I have in my Renderer, and therefore it needs to keep an object called geometryMap. To me this seems like overkill, but maybe there was a good reason for this approach?

[bartvde]

Tests still pass in FF3.6 and Safari 4.

However 1 test is failing on Safari for Renderer.SVG, but this is unrelated to this change:

test_svg_importsymbol fail 1 ok 1
fail Square symbol rendered correctly. eq: values differ: got 0001111000, but expected 0,00,11,11,00,0

Please review.

[fredj]

Safari Renderer.SVG tests: #2710

[fredj]

in OpenLayers.Renderer.Elements.eraseGeometry(), the function is recursively called (line 865): the featureId should be added the the function call.

[bartvde]

updated patch fredj's improvement

[fredj]

tests pass in Chrome, please commit

[bartvde]

(In [10435]) Renderer: give featureId to eraseGeometry function, r=fredj (closes #2693)