Ticket #2643 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

GetFeature select by click should allow to select several features

Reported by: pgiraud Owned by:
Priority: minor Milestone: 2.10 Release
Component: Control.GetFeature Version: 2.9
Keywords: Cc:
State: Complete

Description

Currently, when using the GetFeature control, when user clicks on the map, if several features are retrieved, only the best matching one is kept. In many cases, several features can be found in a single location. I propose we let application decide if it only wants one (the best one) or several results. The attached patch introduces a new single config parameter (set to true by default for compatibility), and renames the selectSingle method to selectClick.

Tests pass on FF3.6, IE8, and Chrome. Please review.

Attachments

patch-2643-A0.diff Download (3.4 KB) - added by pgiraud 3 years ago.
patch-2643-A1.diff Download (4.1 KB) - added by elemoine 3 years ago.

Change History

Changed 3 years ago by pgiraud

Changed 3 years ago by pgiraud

  • owner set to ahocevar
  • state set to Review
  • component changed from general to Control.GetFeature

Changed 3 years ago by pgiraud

  • owner ahocevar deleted

Changed 3 years ago by elemoine

Changed 3 years ago by elemoine

  • state changed from Review to Commit

Pierre, it looks good. patch-2643-A1.diff Download just brings some changes to the doc strings. Tests also pass in Chromium 5 and IE 7. Please commit if you agree with my changes.

Changed 3 years ago by pgiraud

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10361]) added a single config option to allow several features as a result of a click (or 'zero extent' box), r=elemoine, (Closes #2643)

Note: See TracTickets for help on using tickets.