Ticket #2625 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

upgrade to XMLHttpRequest 1.0.4

Reported by: bartvde Owned by: tschaub
Priority: minor Milestone: 2.10 Release
Component: Request Version: 2.9
Keywords: Cc:
State: Complete

Description

Since Sergey has given us permission to change his license for the OpenLayers project back to Apache, we can now upgrade to the latest version of his library, 1.0.3.

Attachments

ticket2625.patch Download (6.4 KB) - added by bartvde 3 years ago.
xmlhttp104.patch Download (10.6 KB) - added by bartvde 3 years ago.
patch to upgrade to XMLHttpRequest 1.0.4

Change History

Changed 3 years ago by bartvde

  Changed 3 years ago by bartvde

  • state set to Review

Tests still pass in FF3.5 and IE6, please review.

follow-up: ↓ 3   Changed 3 years ago by elemoine

It looks good to me. Has someone verified that it solves the problem described in #2065?

in reply to: ↑ 2   Changed 3 years ago by bartvde

Replying to elemoine:

It looks good to me. Has someone verified that it solves the problem described in #2065?

I just checked and it doesn't fix this issue unfortunately. I'll contact Sergey about this.

  Changed 3 years ago by bartvde

See  http://trac.openlayers.org/ticket/2065#comment:6 for Sergey's reply, it is actually an invalid use of his library.

  Changed 3 years ago by bartvde

  • summary changed from upgrade to XMLHttpRequest 1.0.3 to upgrade to XMLHttpRequest 1.0.4

1.0.4 has been released which should fix ticket:2587 as well

Changed 3 years ago by bartvde

patch to upgrade to XMLHttpRequest 1.0.4

  Changed 3 years ago by bartvde

Phil has confirmed this fixed his issue with local files in IE8, and we have fixed ticket:2065 in the OpenLayers library instead, so I think this is good to go.

Please review.

  Changed 3 years ago by ahocevar

  • state changed from Review to Commit

Looks good. Please commit.

  Changed 3 years ago by bartvde

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10345]) upgrade to XMLHttpRequest version 1.0.4 since we got permission from the author Sergey Ilinsky to relicense his library under the Apache license, r=elemoine,ahocevar (closes #2625)

Note: See TracTickets for help on using tickets.