Ticket #2565 (new task)

Opened 3 years ago

Last modified 2 years ago

Create convenience Layer for SOS

Reported by: bartvde Owned by: bartvde
Priority: minor Milestone: Future
Component: Layer Version: 2.8
Keywords: SOS layer Cc:
State: Needs More Work

Description

Create Layer.SOS so that it is easier for people to use the SOS support

Attachments

2565.patch Download (14.3 KB) - added by bartvde 3 years ago.

Change History

  Changed 3 years ago by bartvde

  • state set to Review

One thing to note about this patch is that in order to get the load events right, I had to add a property to the Fixed strategy so that it optionally does not trigger the loadstart event. This is because the SOS layer will first do a GetCapabilities request before it can activate the strategy, so the loadstart event is triggered by the layer instead before retrieving the GetCapabilities.

Tests pass in FF 3.6, IE8 and Safari 4, please review.

Changed 3 years ago by bartvde

  Changed 2 years ago by erilem

  • state changed from Review to Needs Discussion

Bart, is the change to the Fixed strategy required? Is it really an issue that loadstart occurs after the reception of the capabilities? /me not a big fan of adding such "random" option. The rest looks fine to me.

follow-up: ↓ 4   Changed 2 years ago by bartvde

Hi Eric, IIRC it was necessary to get the layer to play nicely with the LoadingPanel addin. Do you have any other suggestion on how to accomplish that?

in reply to: ↑ 3   Changed 2 years ago by erilem

Replying to bartvde:

Hi Eric, IIRC it was necessary to get the layer to play nicely with the LoadingPanel addin. Do you have any other suggestion on how to accomplish that?

Personally I would have kept the capabilities related stuff outside the layer.

follow-up: ↓ 6   Changed 2 years ago by bartvde

  • state changed from Needs Discussion to Needs More Work

Agreed, so I am changing the state to Needs More Work, since I don't have the time before the 2.11 release.

in reply to: ↑ 5   Changed 2 years ago by erilem

  • milestone changed from 2.11 Release to Future

Replying to bartvde:

Agreed, so I am changing the state to Needs More Work, since I don't have the time before the 2.11 release.

So I'm also setting Milestone to Future.

Note: See TracTickets for help on using tickets.