Ticket #2563 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

labelAlign with one character can not works on IE

Reported by: avlee Owned by: ahocevar
Priority: minor Milestone: 2.10 Release
Component: Renderer.VML Version: 2.9 RC1
Keywords: Cc:
State: Complete

Description

See http://openlayers.org/pipermail/dev/2010-April/005834.html

Attachments

vml.patch Download (0.8 KB) - added by avlee 3 years ago.
labelAlign.patch Download (0.9 KB) - added by madair 3 years ago.

Change History

Changed 3 years ago by avlee

  Changed 3 years ago by fredj

  • version changed from 2.8 to SVN
  • milestone changed from 2.10 Release to 2.9 Release

follow-up: ↓ 6   Changed 3 years ago by bartvde

fredj, any specific reason why you changed the milestone on this one? Since it is not a regression from OL 2.8, I want to bump this to 2.10 if you don't mind. Let me know.

  Changed 3 years ago by bartvde

  • state set to Review

Since it has a patch, set to review.

  Changed 3 years ago by tschaub

  • state changed from Review to Commit

This looks good to me. If tests pass and any relevant examples work, I think it is good to commit. Whether it belongs in 2.9 depends on whether we have another RC.

  Changed 3 years ago by tschaub

  • owner changed from ahocevar to fredj

in reply to: ↑ 2   Changed 3 years ago by fredj

Replying to bartvde:

fredj, any specific reason why you changed the milestone on this one? Since it is not a regression from OL 2.8, I want to bump this to 2.10 if you don't mind. Let me know.

It's not a regression but setting only one character works with the svg renderer and the change is small, that's why I've changed the milestone.

The "real" issue is that we don't have unit tests for the feature style...

  Changed 3 years ago by fredj

  • keywords pullup added
  • state changed from Commit to Pullup

(In [10172]) Renderer.VML: allow one character for labelAlign. p=avlee, r=bartvde,tschaub (pullup #2563)

  Changed 3 years ago by bartvde

  • status changed from new to closed
  • resolution set to fixed

Pullup done in r10175

  Changed 3 years ago by bartvde

  • version changed from SVN to 2.9 RC1

  Changed 3 years ago by madair

  • status changed from closed to reopened
  • resolution fixed deleted

this patch breaks the labelAlign in IE7 because it appears that strings can't be treated as an array and the net effect is that labelAlign will always be 'cm'. To demonstrate this, run the vector-features-with-text example in IE7 (or IE8 compatibility mode).

The attached patch assumes that if there is a one char labelAlign, it is the only the horizontal alignment and vertical align defautls to 'm' in this case.

Changed 3 years ago by madair

  Changed 3 years ago by bartvde

  • milestone changed from 2.9 Release to 2.10 Release

  Changed 3 years ago by bartvde

  • state changed from Pullup to Review

  Changed 3 years ago by ahocevar

  • owner changed from fredj to ahocevar
  • status changed from reopened to new

  Changed 3 years ago by ahocevar

  • keywords pullup removed
  • status changed from new to closed
  • state changed from Review to Complete
  • resolution set to fixed

(In [10646]) don't treat strings as array. p=madair, r=me (closes #2563)

Note: See TracTickets for help on using tickets.