Ticket #2558 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

Superfluous "limit" in Layer.XYZ

Reported by: Joto Owned by: euzuro
Priority: minor Milestone: 2.9 Release
Component: Layer Version: 2.9 RC1
Keywords: pullup Cc:
State: Pullup

Description

The getURL function in Layers.XYZ contains the line

var limit = Math.pow(2, z);

But this limit is never used. It is probably a left-over from a check that the x/y-coordinates are within the limits. (OpenLayers tends to generate tile requests for tiles numbered -1 etc.) This line should either be removed or the check should be added.

Attachments

2558.0.patch Download (461 bytes) - added by fredj 3 years ago.
remove unused variable

Change History

Changed 3 years ago by fredj

remove unused variable

Changed 3 years ago by fredj

  • keywords xyz limit removed
  • state set to Review

tests pass, please review.

Changed 3 years ago by bartvde

  • state changed from Review to Commit

Changed 3 years ago by fredj

should we change the milestone to 2.9 and commit now or wait after the 2.9 release ?

Changed 3 years ago by bartvde

Hi fredj, since this is not urgent, I would like to leave it at the 2.10 milestone, otherwise 2.9 will never get done.

It can be committed now in trunk, but I won't pull it up to the 2.9 branch.

Changed 3 years ago by bartvde

  • milestone changed from 2.10 Release to 2.9 Release

Okay since RC2 has not yet been tagged etc. and the vote is still out, I've changed my mind to also include this in RC2. So please commit in trunk with state pullup.

Changed 3 years ago by fredj

  • keywords pullup added
  • state changed from Commit to Pullup

Changed 3 years ago by bartvde

Fredj, the commit for this one still needs to be done right?

Changed 3 years ago by fredj

it's commited: r10182 (but the pullup keyword doesn't worked)

Changed 3 years ago by bartvde

  • status changed from new to closed
  • resolution set to fixed

Changed 3 years ago by bartvde

Pulled up in r10185 to the 2.9 branch

Changed 3 years ago by bartvde

  • version changed from 2.8 to 2.9 RC1
Note: See TracTickets for help on using tickets.