Ticket #2529 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Renderer.VML: missing semicolon, global variables

Reported by: fredj Owned by: fredj
Priority: trivial Milestone: 2.9 Release
Component: Renderer.VML Version: SVN
Keywords: Cc:
State: Complete

Description

found by  http://www.jslint.com/

Index: lib/OpenLayers/Renderer/VML.js
===================================================================
--- lib/OpenLayers/Renderer/VML.js	(revision 10101)
+++ lib/OpenLayers/Renderer/VML.js	(working copy)
@@ -240,7 +240,7 @@
                 node.style.flip = "y";
                 
                 // modify fillColor and options for stroke styling below
-                fillColor = "none"
+                fillColor = "none";
                 options.isStroked = false;
             } else if (this.isComplexSymbol(style.graphicName)) {
                 var cache = this.importSymbol(style.graphicName);
@@ -941,8 +941,8 @@
         
         var pathitems = ["m"];
         for (var i=0; i<symbol.length; i=i+2) {
-            x = symbol[i];
-            y = symbol[i+1];
+            var x = symbol[i];
+            var y = symbol[i+1];
             symbolExtent.left = Math.min(symbolExtent.left, x);
             symbolExtent.bottom = Math.min(symbolExtent.bottom, y);
             symbolExtent.right = Math.max(symbolExtent.right, x);

Change History

Changed 3 years ago by bartvde

  • owner changed from ahocevar to fredj
  • state changed from Review to Commit

Looks good, please commit.

Changed 3 years ago by fredj

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10111]) add missing semicolon, remove global variables. r=bartvde (closes #2529)

Note: See TracTickets for help on using tickets.