Ticket #2519 (closed feature: invalid)

Opened 3 years ago

Last modified 3 years ago

Attribution control: implement the methods activate/deactivate.

Reported by: jorix Owned by: jorix
Priority: trivial Milestone: 2.10 Release
Component: Control.Attribution Version: SVN
Keywords: Cc:
State:

Description

The attached patch implements the methods activate/deactivate on the control.

Requires patch #2518.

The tests are passed successfully in: IE8, FF36 and CH4.

SVN Revision Number: 10094

Attachments

ControlAttribution-2519.patch Download (2.5 KB) - added by jorix 3 years ago.
ControlAttribution-2519(2).patch Download (2.8 KB) - added by jorix 3 years ago.
(without dependence on other tickets)

Change History

Changed 3 years ago by jorix

Changed 3 years ago by jorix

  • keywords review added
  • state set to Review

please review this ticket, and the others who have opened today and last week.

Changed 3 years ago by bartvde

  • milestone changed from 2.10 Release to 2.9 Release

Changed 3 years ago by bartvde

  • milestone changed from 2.9 Release to 2.10 Release

Moving forward since it depends on ticket:2518

Changed 3 years ago by jorix

  • owner set to jorix

Changed 3 years ago by jorix

  • keywords review removed

Now depends on ticket #2629

Changed 3 years ago by jorix

  • priority changed from minor to trivial

Changed 3 years ago by jorix

I removed the dependence of #2629. Now the ticket is autonomous.

SVN 10507

Changed 3 years ago by jorix

  • state Review deleted

Changed 3 years ago by jorix

(without dependence on other tickets)

Changed 3 years ago by jorix

  • state set to Review

I removed the dependence of #2629. Now the ticket is autonomous.

SVN 10507

Plase review

Changed 3 years ago by ahocevar

  • status changed from new to closed
  • state Review deleted
  • resolution set to invalid

Maybe a stupid question, but why would someone want to deactivate the attribution control? First, it is one of the default controls of OpenLayers. Second, if a layer has an attribution, there is a reason to display it (e.g. because it is required by its terms of use).

I am not in favor of making the Attribution control more bloated. Correct me if I'm wrong by reopening this ticket.

Note: See TracTickets for help on using tickets.