Panel, new features: Save status and visibility of controls + any problems solved.

[jorix]

Major changes in addControls.

Features:

• Save status of active controls when panel is deactivated and restore it at activation. This is handled by two new properties of the panel controls: activeByDefault and wasActive.
• New property visibility for controls into panel.
• New method setOptionsControls that allows change properties of panel controls.
• New parameter forcedOptions of addControls method for set the same properties to all controls added.

See "addControls" function documentation in the patch for more details.

problems solved:

• Prevent unnecessary extra redraw.
• Prevents some activations followed by deactivations in controls into the panel, this occurs when the controls have autoActivate=true.
• Prevents the activation of the panel when it has autoActivate=false.

The attached patch fixes this.

Test need patch #2506, work ok in IE8, FF35 and CH4.

SVN Revision Number: 10094

[jorix]

Patch of control panel

[jorix]

please review this ticket, and the others who have opened today.

[bartvde]

Feature so moving forward to next release.

[jorix]

Replying to bartvde:

Feature so moving forward to next release.

I've seen more tickets for review at 2.10. Some are quite old, and this has disturbed me. I looked at the Control.Panel tickets too, and I found the #2421, I think is invalid (confusing controls[i].div with controls[i].panel_div) but has no comment and still under review.

In my OL speech, I use xxx.prototype.xxx.apply for overwritten OL methods to ensure upward compatibility through the versions. Because this, convert to patches and test it has brought me some effort, see: #2501, #2506, #2507, #2508, #2518, #2519, #2520 and #2521, without forget the #2509. And of course I had fun with it, and I have a few more details that could add.

As you make revisions? When done? Looks well these tickets?

I understand 2.9 now require concentrating work. Once stable, I prefer that you close my tickets as invalid that let it long time without review.

Tell me something.

Thanks.

[bartvde]

Hi Jorix, please remembering that reviewing tickets is something that people have to do unpaid, in their spare time.

It does not mean your tickets will not be reviewed at all, it might take some time though before people have the incentive and time to look at them. So please don't see this as a discouragement for the work you have done, and for which we are grateful.

[jorix]

Corrects the treatment of visibility and added benefits for the use of display classes

[jorix]

Peter, thanks for your comments of encouragement.

---

ControlPanel-2507(2).patch corrects the treatment of visibility and added benefits for the use of display classes.

Now control display classes may be different from those associated with the control icon inside the panel.

It also introduces changes to implement #1414.

Notes for down Compatibility:

• Set saveStatus to false.
• When you add a toggle control may be appropriate to put corresponding AutoActivate to false.

Please review.

[jorix]

bartvde, thanks for your comments of encouragement (sorry, in up I said Peter instead of bartvde, bad cut and paste!).

[jorix]

new type of control implemented

[jorix]

Please review

[jorix]

I am working to split it into multiple tickets or simplify.

[jorix]

See #2650