Ticket #2501 (closed bug: duplicate)

Opened 3 years ago

Last modified 3 years ago

Measure Control: Two bugs with partial measure + 2 features

Reported by: jorix Owned by: jorix
Priority: minor Milestone: 2.10 Release
Component: Control.Measure Version: SVN
Keywords: Cc:
State:

Description

Measure Control: Two bugs with partial measure + 2 features.

Bugs:

  • The initial click displays a value other than zero (resolves also tickets: #2094 and #2096).
  • Some triggerEvent of measurepartial after measureComplete. Occurs when: measuring pressing shift key, and finish by mouse up.

Features:

  • Simultaneously measuring lengths and areas.
  • In normal use, the measurements are displayed immediately.

The patch includes changes in control "Measure.js" and in test "Measure.html" (for a new "test_measure").

Successfully passed the tests in: IE8, FF5 and CH4.

SVN Revision Number: 10094

Attachments

ControlMeasure-2501.patch Download (8.3 KB) - added by jorix 3 years ago.
Patch to fix these bugs
ControlMeasure-2501(2).patch Download (8.9 KB) - added by jorix 3 years ago.
fixes problems with IE

Change History

Changed 3 years ago by jorix

Patch to fix these bugs

  Changed 3 years ago by jorix

  • keywords review added
  • state set to Review
  • type changed from feature to bug

I lost a 3, is not FF5, is FF35.

please review this ticket, and the others who have opened today.

  Changed 3 years ago by bartvde

  • milestone changed from 2.10 Release to 2.9 Release

  Changed 3 years ago by bartvde

  • milestone changed from 2.9 Release to 2.10 Release

Not a regression so bumping to 2.10.

Changed 3 years ago by jorix

fixes problems with IE

  Changed 3 years ago by jorix

I did not test well with IE, I had put DOCTYPE. With IE when double-clicking fails is in quirks mode (not finished the measurement).

I corrected the code reaching a compromise. The double click IE fails only if it is the initial click. This should not be a problem, it gets as 0 and the next double click will end the measurement correctly (the user can think: it makes no sense end of the measurement to the first click, is not a bug!).

It is not possible the second feature: Now the measurements in normal use are deferred as before.

please review

  Changed 3 years ago by jorix

  • owner changed from tschaub to jorix

  Changed 3 years ago by jorix

  • state changed from Review to Needs More Work

I am working to split it into multiple tickets

  Changed 3 years ago by jorix

  • keywords review removed

follow-up: ↓ 9   Changed 3 years ago by ahocevar

  • status changed from new to closed
  • resolution set to duplicate

duplicate of one or more of #2094, #2096, #2635

in reply to: ↑ 8   Changed 3 years ago by jorix

Replying to ahocevar:

duplicate of one or more of #2094, #2096, #2635

This ticket has been split in:

  Changed 3 years ago by jorix

  • state Needs More Work deleted
Note: See TracTickets for help on using tickets.