Ticket #2500 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

Rendering a previously rotated geometry will not rotate it back

Reported by: ahocevar Owned by: ahocevar
Priority: minor Milestone: 2.9 Release
Component: Renderer Version: 2.8
Keywords: Cc:
State: Complete

Description

If a rotated geometry is re-rendered and no rotation symbolizer property is set, the geometry will be re-rendered with the old rotation. This should be changed.

The attached patch fixes this issue. Tests still pass, graphic-name.html example shows the correct behavior (hover over feature -> rotate, move away from feature -> rotate back).

Please review.

Attachments

openlayers-2500.patch Download (2.9 KB) - added by ahocevar 3 years ago.

Change History

Changed 3 years ago by ahocevar

Changed 3 years ago by ahocevar

  • state set to Review

Changed 3 years ago by bartvde

  • milestone changed from 2.10 Release to 2.9 Release

Changed 3 years ago by bartvde

  • owner set to ahocevar
  • state changed from Review to Commit

Good catch Andreas, patch looks good, I've tested the example in IE6 and FF3.6, and run tests as well. All is fine.

Changed 3 years ago by ahocevar

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10135]) fixing rotation so previously rotated geometries will be rotated back if the rotation symbolizer attribute is not set any more. r=bartvde (closes #2500)

Note: See TracTickets for help on using tickets.