Ticket #2490 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

ArcIMS as base layer blows up the Overview Map control

Reported by: vbokin Owned by: tschaub
Priority: critical Milestone: 2.10 Release
Component: Control.OverviewMap Version: 2.8
Keywords: Cc:
State: Complete

Description

When an ArcIMS layer is a base layer, the overview map doesn't load and errors are throw in

Grid.js.addTileMonitoringHooks(tile)

the "tile" that is passed is undefined. I was able to trace it back to

Grid.js.initGriddedTiles(..)

=> line 408

 if (!tile) {
                    tile = this.addTile(tileBounds, px);
                    this.addTileMonitoringHooks(tile);
                    row.push(tile);
                } else {
                    tile.moveTo(tileBounds, px, false);
                }

The call to

tile = this.addTile(tileBounds, px);

returns UNDEFINED. So it seems that the actual error is in ArcIMS.js.addTile(...)

To replicate:

1) Take the basic ArcIMS example

 http://www.openlayers.org/dev/examples/arcims.html

2) Add 1 line at the end of the init() routine to add the overview map

    map.addControl (new OpenLayers.Control.OverviewMap( ) ); 

3) Load sample HTML file -> map loads, but the overview control throws errors

Attachments

ticket2490.patch Download (2.4 KB) - added by bartvde 3 years ago.
implement clone method for ArcIMS layer (with testcase)

Change History

Changed 3 years ago by bartvde

I believe this is caused by OpenLayers.Layer.ArcIMS missing a specific implementation for clone.

Changed 3 years ago by bartvde

implement clone method for ArcIMS layer (with testcase)

Changed 3 years ago by bartvde

  • state set to Review

Tests pass in FF 3.6, please review.

Changed 3 years ago by bartvde

  • milestone changed from 2.10 Release to 2.9 Release

Changed 3 years ago by bartvde

  • milestone changed from 2.9 Release to 2.10 Release

Not a regression, so bumping as well.

Changed 3 years ago by crschmidt

  • keywords overviewmap,arcims,overview map removed
  • status changed from new to closed
  • state changed from Review to Complete
  • resolution set to fixed

(In [10666]) ArcIMS layer does not have a proper clone method. patch=bartvde, r=me, tests pass in Safari and IE, (Closes #2490)

Note: See TracTickets for help on using tickets.