wrong fillColor with externalGraphic and Collection geometry

[fredj]

If the VML renderer draws a collection of point and polygon with an externalGraphic set, the polygon fillColor is set to none.

Because:

• OpenLayers.Renderer.Elements.drawGeometry() calls setStyle for the point and pass the style object.
• OpenLayers.Renderer.VML.setStyle() update the style object (line 242 and 243)
• OpenLayers.Renderer.Elements.drawGeometry() calls setStyle for the polygon and pass the same style object.

The polygon fillColor is none.

[ahocevar]

Thanks fredj for the verbose description of what happens - with that in my hands it was easy to fix the issue (see attached patch).

Tests still pass, loading  http://finder.geocommons.com/overlays/download/4433.kml into the vector-formats example returns the same result as in browsers with SVG rendering. Please review.

[fredj]

local copy of style.fillColor and options.isStroked

[fredj]

forget attachment:openlayers-2485.1.patch : options argument is build in drawGeometryNode and not reused for collection geometry.

Please commit attachment:openlayers-2485.patch

[ahocevar]

(In [10063]) fixed VML renderer so it does not change fillColor on node._style anymore when rendering externalGraphic. r=fredj (closes #2485)