Ticket #2448 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

Format.KML - typo - missing break in case declaration

Reported by: pgiraud Owned by: tschaub
Priority: minor Milestone: 2.9 Release
Component: Format.KML Version: 2.8
Keywords: Cc:
State: Complete

Description

See attached patch

Attachments

patch_2448.diff Download (480 bytes) - added by pgiraud 3 years ago.
patch_2448.2.diff Download (4.2 KB) - added by pgiraud 3 years ago.
patch with fixed tests
patch_2448.3.diff Download (4.4 KB) - added by pgiraud 3 years ago.
fill tag take a boolean as value

Change History

Changed 3 years ago by pgiraud

Changed 3 years ago by crschmidt

  • state set to Commit

Changed 3 years ago by pgiraud

  • state changed from Commit to Needs More Work

Actually tests are broken and for a good reason. There is no break for a good reason too, it seems.

I can't commit. This would be a very bad idea.

Changed 3 years ago by pgiraud

patch with fixed tests

Changed 3 years ago by pgiraud

  • state changed from Needs More Work to Review

Actually, the tests were wrong. We were looking for a fillColor in a lineStyle. Now tests are ok.

Please review.

Changed 3 years ago by pgiraud

  • state changed from Review to Needs More Work

Changed 3 years ago by pgiraud

fill tag take a boolean as value

Changed 3 years ago by pgiraud

  • state changed from Needs More Work to Review

Changed 3 years ago by fredj

In tests/Format/KML.html, function test_Format_KML_extractStyleFill there is two f.read(test_style_fill). The second can be removed.

Changed 3 years ago by fredj

  • state changed from Review to Commit

Changed 3 years ago by pgiraud

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10006]) we were missing a break statement in the KML parseStyle method, tests are modified accordingly, r=fredj (Closes #2448)

Note: See TracTickets for help on using tickets.