Ticket #2421 (new feature)

Opened 3 years ago

Last modified 2 years ago

Improve the panel control

Reported by: avlee Owned by:
Priority: minor Milestone: Future
Component: Control.Panel Version: 2.8
Keywords: Cc:
State: Needs More Work

Description

Recently, I want to extend the panel control to create some more complex controls, but I found that when the child controls is activated or inactivated the Panel control will always re-draw the child controls, and include invasive behavior which is not conducive to apply CSS style to the child controls.

So I rewrote the Panel control to make it simpler and more beneficial to be extended.

Attachments

panel.patch Download (6.6 KB) - added by avlee 3 years ago.
Panel_2421_2.patch Download (4.7 KB) - added by avlee 2 years ago.

Change History

Changed 3 years ago by avlee

  Changed 3 years ago by avlee

  • state set to Review

  Changed 3 years ago by bartvde

  • milestone changed from 2.10 Release to 2.9 Release

  Changed 3 years ago by bartvde

  • milestone changed from 2.9 Release to 2.10 Release

Not a regression so bumping to 2.10.

  Changed 2 years ago by erilem

  • state changed from Review to Needs More Work
  • milestone changed from 2.11 Release to Future

panel.patch Download doesn't apply to current trunk. Also, the patch doesn't include changes to the Panel tests, and it is unlikely that such a patch wouldn't require changes to the Panel tests. Bumping.

Changed 2 years ago by avlee

  Changed 2 years ago by avlee

I attached a new patch, the patch's goal is to avoid the controls are removed from the DOM when activate or deactivate the controls, a further goal is to make the panel control to accommodate more complex controls, not just the button. Currently supports more complex controls needs more work.

This is doing the right thing? If not, we can close this ticket.

  Changed 2 years ago by erilem

  • milestone changed from Future to 2.11 Release

follow-up: ↓ 8   Changed 2 years ago by avlee

  • milestone changed from 2.11 Release to Future

in reply to: ↑ 7   Changed 2 years ago by jorix

Hi avlee

In response to your comment:9 in #2906:

Yes I know this ticket, but my approach was different, see #2862 and also the initial approach of #2946.

I also I have written code to control the visibility of the control icons on the panel, to create icons with text, and also to include a type of custom control into panels. But I have not posted any of these proposals. OpenLayers team is not too open to proposals in this area.

Regards,

Xavier

Note: See TracTickets for help on using tickets.