selecting features using a box shouldn't select unrendered features

[pgiraud]

In the SelectFeature control, the selectBox method doesn't take care about whether the feature is rendered or not.

Please review the attached patch.

[elemoine]

although I think it's correct that, in the current code, features with display:none are in the unrenderedFeatures object I'm not sure it's good idea to rely on that object to look up features that aren't displayed. The documentation for undereredFeatures says: hash of features, keyed by feature.id, that the renderer failed to draw, so the purpose of this object doesn't include storing features that aren't rendered because their "display" property is set to "none". I'd to know what others - ahocevar in particular - think about that.

[ahocevar]

There are several reasons why features can end up in the unrenderedFeatures object, and these are not consistent among renderers. So this is definitely not the condition to check. While the patch will work with SVG renderers, it will most likely fail with others. The correct way to check whether a feature is displayed is to check for the "display" symbolizer property:

• feature.style.display
• feature.layer.styleMap ? feature.layer.styleMap.createSymbolizer(feature, feature.renderIntent).display
• feature.layer.style.display

[pgiraud]

patch with Andreas recommandations

[pgiraud]

I just attached a new patch. It takes Andreas' great recommendations into account. It looks like it's the way to go. I'm currently writing tests to add to this patch for the new Feature.Vector.isDisplayed() method but you can already take a look at the patch.

[pgiraud]

same patch with unit tests for the new "isDisplayed" method

[ahocevar]

Looks good. One suggestion: rename the new isDisplayed method to getVisibility, to be consistent with the Layer API. Please commit after making this change and if you can confirm that tests pass.

[pgiraud]

(In [10064]) adds a new getVisibility method in the Feature.Vector class, used in the SelectFeature control this method now allows us to tell the select feature box handler wether to select or not the features, r=ahocevar, (Closes #2418)