Ticket #2407 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

olImageLoadError class name added but never removed

Reported by: tschaub Owned by:
Priority: minor Milestone: 2.9 Release
Component: Util Version: 2.8
Keywords: Cc:
State: Complete

Description

I'm seeing cases where an image loading error causes the olImageLoadError class to be applied, and then later when the same image has successfully loaded (zooming out) the style declarations from the error block are still applied. Though it seems like this would be a cross browser problem, I'm only seeing it on IE, where the opacity filter still applies after the image successfully loads.

The problem goes away when I remove the olImageLoadError in the "success" handler. This certainly seems like good practice even if it is not completely clear why the problem doesn't manifest itself in all browsers.

Attachments

2407.patch Download (1.3 KB) - added by tschaub 3 years ago.
remove image error class name

Change History

Changed 3 years ago by tschaub

remove image error class name

Changed 3 years ago by tschaub

  • state set to Review

Tests pass on FF3.5 and IE8. Thanks for any review.

Changed 3 years ago by ahocevar

  • state changed from Review to Commit

Exactly the right thing to do -- good catch! Please commit.

Changed 3 years ago by tschaub

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [9940]) Removing any onImageLoadError class name from images when they successfully load. r=ahocevar (closes #2407)

Note: See TracTickets for help on using tickets.