Ticket #2404 (closed feature: fixed)

Opened 3 years ago

Last modified 3 years ago

MousePosition control should support mouseOut event

Reported by: cmoullet Owned by: crschmidt
Priority: minor Milestone: 2.9 Release
Component: Control.MousePosition Version: 2.8
Keywords: Cc:
State: Complete

Description

If the mouse is outside the map, the last position within the map is presented. This is not logical, since the map is not in the map anymore. The attached patch proposed to react to the map mouseOut event in order to be able to associate an "emptyString" to the mouse position.

Attachments

MousePosition.patch Download (1.2 KB) - added by cmoullet 3 years ago.
MousePositionTest.patch Download (0.9 KB) - added by cmoullet 3 years ago.
mp.patch Download (3.9 KB) - added by crschmidt 3 years ago.

Change History

Changed 3 years ago by cmoullet

Changed 3 years ago by cmoullet

Add a patch for the tests

Changed 3 years ago by cmoullet

Changed 3 years ago by bartvde

  • milestone changed from 2.10 Release to 2.9 Release

Changed 3 years ago by crschmidt

I would like to propose this change:

  1. Make emptyString default to null
  2. Only actually reset the string if it is not null

This maintains the current behavior by default -- which I think is valuable.

Changed 3 years ago by crschmidt

Changed 3 years ago by crschmidt

Attached a patch for that change.

Changed 3 years ago by bartvde

  • owner set to crschmidt
  • state changed from Review to Commit

Looks good Chris except for the typo in the test page ( ehtml> ). Please commit. Tests pass in IE6 and FF3.6

Changed 3 years ago by crschmidt

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [10127]) "MousePosition control should support mouseOut event", r=bartvde, initial patch cmoullet, (Closes #2404)

Note: See TracTickets for help on using tickets.